From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MLza8-0006HT-P4 for mharc-grub-devel@gnu.org; Wed, 01 Jul 2009 09:10:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLza6-0006Dv-5F for grub-devel@gnu.org; Wed, 01 Jul 2009 09:10:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLza0-00061z-Ga for grub-devel@gnu.org; Wed, 01 Jul 2009 09:10:32 -0400 Received: from [199.232.76.173] (port=57522 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLza0-00061d-9N for grub-devel@gnu.org; Wed, 01 Jul 2009 09:10:28 -0400 Received: from aybabtu.com ([69.60.117.155]:56988) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MLzZz-0006rI-Rl for grub-devel@gnu.org; Wed, 01 Jul 2009 09:10:28 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MLyWB-0007T3-5l for grub-devel@gnu.org; Wed, 01 Jul 2009 14:02:27 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MLzZx-0004fn-CU for grub-devel@gnu.org; Wed, 01 Jul 2009 15:10:25 +0200 Date: Wed, 1 Jul 2009 15:10:25 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090701131025.GD17770@thorin> References: <20090701003502.25373.82948.stgit@mj.roinet.com> <20090701003509.25373.35314.stgit@mj.roinet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090701003509.25373.35314.stgit@mj.roinet.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2009 13:10:35 -0000 On Tue, Jun 30, 2009 at 08:35:09PM -0400, Pavel Roskin wrote: > + if (modlist != "") { Are you sure this does what you expect? I read it as "compare this char * with this const char *", which will always return false. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."