All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 1/3] Improve genmoddep.awk
Date: Wed, 1 Jul 2009 15:13:11 +0200	[thread overview]
Message-ID: <20090701131310.GE17770@thorin> (raw)
In-Reply-To: <ca0f59980906302222v267addcdr849808d0fbbb87fc@mail.gmail.com>

On Wed, Jul 01, 2009 at 01:22:29PM +0800, Bean wrote:
> On Wed, Jul 1, 2009 at 12:51 PM, Pavel Roskin<proski@gnu.org> wrote:
> > Quoting Bean <bean123ch@gmail.com>:
> >
> >> Perhaps you could also take a look at my previous patch
> >>
> >> [PATCH] Use symbol database to maintain module dependence
> >>
> >> It add a program grub-symdb to maintain symbol database and therefore
> >> eliminate def- and unf- files, it also allows incremental build.
> >
> > grub-symdb would need to be compiled by a native C compiler.  Otherwise, it
> > won't work when cross-compiling the utilities.
> >
> > It's not that it's a big deal per se, but it is will add complexity if we
> > try to use autoconf to look for it.
> >
> > Adding grub-symdb to bin_UTILITIES would result in it being installed along
> > with the utilities that are actually used after the build.  I think it's
> > wrong.  Temporary build tools don't belong there.
> 
> Hi,
> 
> Actually, that's the intention. grub-symdb and the symbol database is
> supposed to be installed in the target system. They can be used to
> support external grub modules. To install new package, we can just
> copy the modules files and use rerun grub-symdb to update the
> database.

I tend to agree with Pavel.  We should be careful about adding complexity,
and only do it when we're sure it's going to pay off.

(I'm not saying it doesn't pay off here, but this factor should always be
taken into account IMO)

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



      parent reply	other threads:[~2009-07-01 13:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01  0:35 [PATCH 1/3] Improve genmoddep.awk Pavel Roskin
2009-07-01  0:35 ` [PATCH 2/3] Don't put modules without dependencies into moddep.lst Pavel Roskin
2009-07-01 13:10   ` Robert Millan
2009-07-01 13:20     ` Pavel Roskin
2009-07-04 20:09       ` Robert Millan
2009-07-01  0:35 ` [PATCH 3/3] Use ELF symbols without "32" or "64" Pavel Roskin
2009-07-01  3:44 ` [PATCH 1/3] Improve genmoddep.awk Bean
2009-07-01  4:51   ` Pavel Roskin
2009-07-01  5:22     ` Bean
2009-07-01 12:35       ` Pavel Roskin
2009-07-01 13:13       ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090701131310.GE17770@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.