All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@canonical.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Dave Airlie <airlied@linux.ie>, Eric Anholt <eric@anholt.net>,
	dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] i915: fix up a raw 64bit divide
Date: Wed, 1 Jul 2009 17:32:35 +0100	[thread overview]
Message-ID: <20090701163235.GG13837@shadowen.org> (raw)
In-Reply-To: <20090701091255.363f9d4d@jbarnes-g45>

On Wed, Jul 01, 2009 at 09:12:55AM -0700, Jesse Barnes wrote:
> On Wed,  1 Jul 2009 15:20:59 +0100
> Andy Whitcroft <apw@canonical.com> wrote:
> 
> > We are seeing compilation failures on i386 in some environments due
> > to an undefined reference as below:
> > 
> >     ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!
> > 
> > This is generated due to a raw 64 bit divide in the i915 driver.  Fix
> > up this raw divide.
> > 
> > Signed-off-by: Andy Whitcroft <apw@canonical.com>
> 
> I think building with newer GCCs will prevent this error, but the fix
> looks fine.

Yeah I suspect gcc interactions here, as builds on older userspace were
failing in this way but not so in the very latest karmic userspace.  I
suspect its still correct to avoid these currently.

> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Thanks.

-apw

  reply	other threads:[~2009-07-01 16:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 14:20 [PATCH 1/1] i915: fix up a raw 64bit divide Andy Whitcroft
2009-07-01 16:12 ` Jesse Barnes
2009-07-01 16:32   ` Andy Whitcroft [this message]
2009-07-02  0:59   ` Zhenyu Wang
2009-07-05 10:18   ` Sergio Luis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090701163235.GG13837@shadowen.org \
    --to=apw@canonical.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=eric@anholt.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.