From: Jean Delvare <jdelvare@suse.de>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: Thomas Renninger <trenn@suse.de>,
"Lin, Ming M" <ming.m.lin@intel.com>, Len Brown <lenb@kernel.org>,
"Zhao, Yakui" <yakui.zhao@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: Revert "ACPICA: Remove obsolete acpi_os_validate_address interface"
Date: Thu, 2 Jul 2009 10:20:00 +0200 [thread overview]
Message-ID: <200907021020.00786.jdelvare@suse.de> (raw)
In-Reply-To: <4911F71203A09E4D9981D27F9D8308582EA040F1@orsmsx503.amr.corp.intel.com>
Hi Robert,
Le jeudi 02 juillet 2009, Moore, Robert a écrit :
> could still detect most i2c/smbus/hwmon devices conflicts.
>
> What exactly are these conflicts?
Native Linux drivers trying to access devices which ACPI also wants
to access. Most frequently these are SMBus master drivers or hardware
monitoring drivers (for Super I/O chips) but virtually any other
device type could be affected, due to the fact that ACPI I/O
resources do not show up in /proc/ioports and /proc/iomem.
The workaround written by Thomas would let the native drivers which
are more frequently affected by the problem ask the ACPI subsystem,
on a voluntary basis, if a given I/O range is safe to use. While not
perfect, it worked reasonably well in practice.
Your upstream commit broke this safety mechanism, and now all the
past bugs resulting of native driver vs. ACPI conflicts show up
again, so you will have to fix it now. Either by reverting your
commit, or by coming up with a better safety. I don't know much about
ACPI so I can't really comment on a technical perspective. All I care
about is the functionality: either concurrent access from native
drivers and ACPI must be doable safely, or it must be prevented
altogether (which Thomas' code was doing.)
I will be happy to answer your questions about the native Linux
drivers for SMBus master devices and hardware monitoring devices.
I can also help with testing if you want.
--
Jean Delvare
Suse L3
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-07-02 8:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 2:29 [PATCH] ACPICA: Revert "ACPICA: Remove obsolete acpi_os_validate_address interface" Lin Ming
2009-07-01 8:56 ` Thomas Renninger
2009-07-01 9:23 ` Lin Ming
2009-07-01 9:35 ` Thomas Renninger
2009-07-01 15:29 ` Moore, Robert
2009-07-01 21:19 ` Thomas Renninger
2009-07-01 22:07 ` Moore, Robert
2009-07-02 8:20 ` Jean Delvare [this message]
2009-07-02 8:30 ` Jean Delvare
2009-07-02 2:03 ` Len Brown
2009-07-02 6:27 ` Lin Ming
2009-07-02 6:42 ` Moore, Robert
2009-07-02 10:15 ` Thomas Renninger
2009-07-02 10:12 ` Thomas Renninger
2009-07-03 1:30 ` Lin Ming
2009-07-13 15:36 ` Thomas Renninger
2009-07-14 2:28 ` Lin Ming
2009-07-17 15:02 ` Thomas Renninger
2009-07-02 10:22 ` Thomas Renninger
2009-07-02 15:49 ` Moore, Robert
2009-07-04 1:29 ` Robert Hancock
2009-08-30 13:43 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907021020.00786.jdelvare@suse.de \
--to=jdelvare@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
--cc=trenn@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.