From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: "ext Candelaria Villareal, Jorge" <x0107209@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: TWL4030: Add EXTMUTE to reduce pop-noise effect
Date: Thu, 2 Jul 2009 12:34:57 +0300 [thread overview]
Message-ID: <200907021234.58110.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <2256F256009DAA4CBE661E9F41EAC84B52037758@dlee01.ent.ti.com>
On Thursday 02 July 2009 03:17:43 ext Candelaria Villareal, Jorge wrote:
> According to TRM, an external FET controlled by a 1.8V output signal
> can be used to reduce the pop-noise heard when the audio amplifier is
> switched on. It is suggested that GPIO6 of TWL4030 be used, but any
> other gpio can be used instead. This is indicated in machine driver
> with the following twl4030_setup_data members:
>
> -hs_extmute. Set to 1 if board has support for EXTMUTE.
>
> -set_hs_extmute. Set to a callback funcion to control an external gpio
> line. Set to NULL if MUTE[GPIO6] pin is used.
>
> Codec driver takes care of enabling and disabling this output during
> the headset pop attenuation sequence.
>
> Also add a delay to let VMID settle in ramp up sequence.
I can not see any problems with this patch, but unfortunately I can not test
it since none of my hardware supports the extmute on the headset output...
Thank you!
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
next prev parent reply other threads:[~2009-07-02 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 0:17 [PATCH] ASoC: TWL4030: Add EXTMUTE to reduce pop-noise effect Candelaria Villareal, Jorge
2009-07-02 2:01 ` framework to implement a real time ploter for sound capturing! Guilherme
2009-07-02 2:29 ` Lee Revell
2009-07-02 9:34 ` Peter Ujfalusi [this message]
2009-07-02 10:08 ` [PATCH] ASoC: TWL4030: Add EXTMUTE to reduce pop-noise effect Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907021234.58110.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=x0107209@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.