From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMO9L-0002Gl-Jn
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 11:24:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMO9H-0002CK-JR
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 11:24:34 -0400
Received: from [199.232.76.173] (port=42726 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMO9F-0002Bm-UF
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 11:24:29 -0400
Received: from va3ehsobe005.messaging.microsoft.com ([216.32.180.15]:27648
	helo=VA3EHSOBE005.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Christoph.Egger@amd.com>)
	id 1MMO9F-0005sA-B2
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 11:24:29 -0400
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [Qemu-devel] [PATCH 11/19] configure xen in a single place
Date: Thu, 2 Jul 2009 17:24:19 +0200
References: <cover.1246545655.git.quintela@redhat.com>
	<9ff404766d8d5b7411bb7f154646c98d51c573a1.1246545655.git.quintela@redhat.com>
In-Reply-To: <9ff404766d8d5b7411bb7f154646c98d51c573a1.1246545655.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200907021724.19681.Christoph.Egger@amd.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com

On Thursday 02 July 2009 16:46:35 quintela@redhat.com wrote:
> From: Juan Quintela <quintela@redhat.com>
>
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  configure |   17 +++++++----------
>  1 files changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/configure b/configure
> index 5b35b69..56e4d38 100755
> --- a/configure
> +++ b/configure
> @@ -1991,11 +1991,6 @@ case "$target_cpu" in
>        echo "KVM_CFLAGS=$kvm_cflags" >> $config_mak
>        echo "#define CONFIG_KVM 1" >> $config_h
>      fi
> -    if test "$xen" = "yes" -a "$target_softmmu" = "yes";
> -    then
> -      echo "CONFIG_XEN=y" >> $config_mak
> -      echo "#define CONFIG_XEN 1" >> $config_h
> -    fi
>      target_phys_bits=32
>    ;;
>    x86_64)
> @@ -2014,11 +2009,6 @@ case "$target_cpu" in
>        echo "KVM_CFLAGS=$kvm_cflags" >> $config_mak
>        echo "#define CONFIG_KVM 1" >> $config_h
>      fi
> -    if test "$xen" = "yes" -a "$target_softmmu" = "yes"
> -    then
> -      echo "CONFIG_XEN=y" >> $config_mak
> -      echo "#define CONFIG_XEN 1" >> $config_h
> -    fi
>      target_phys_bits=64
>    ;;
>    alpha)
> @@ -2174,6 +2164,13 @@ esac
>  if [ $target_phys_bits -lt $hostlongbits ] ; then
>    target_phys_bits=$hostlongbits
>  fi
> +case "$target_cpu" in
> +  i386|x86_64)

If 'target_cpu' is set by 'uname -m' then this has to be

+  i386|x86_64|amd64)

or you will break *BSD, otherwise.

> +    if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then
> +      echo "CONFIG_XEN=y" >> $config_mak
> +      echo "#define CONFIG_XEN 1" >> $config_h
> +    fi
> +esac
>  echo "HWLIB=../libhw$target_phys_bits/libqemuhw$target_phys_bits.a" >>
> $config_mak echo "#define TARGET_PHYS_ADDR_BITS $target_phys_bits" >>
> $config_h echo "subdir-$target: subdir-libhw$target_phys_bits" >>
> $config_host_mak



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632