From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Fix wm8753 register cache size and initialization
Date: Fri, 3 Jul 2009 10:32:50 +0100 [thread overview]
Message-ID: <20090703093250.GA29130@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1246574768-11447-1-git-send-email-lars@metafoo.de>
On Fri, Jul 03, 2009 at 12:46:08AM +0200, Lars-Peter Clausen wrote:
> The register cache size is of by one. There are 63 registers in use but the
> register cache size has only space for 62.
Only 62 of the registers are cached - please see the register cache
access code.
> Furthermore the codec's reg_cache_size is of by another one. Since the wm8753
> register cache uses one-based indexing we have to add one to its size.
I'm not 100% sure what you mean here but I suspect you're misreading the
register cache access code?
> Register cache initialization only copied the first sizeof(void*) elements leaving the others
> uninitialized. Fix it by using the size of the reg cache template.
This fix is good (but should use wm8753->reg_cache for the size). I'll
fix this.
next prev parent reply other threads:[~2009-07-03 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 22:46 [PATCH] ASoC: Fix wm8753 register cache size and initialization Lars-Peter Clausen
2009-07-02 22:46 ` Lars-Peter Clausen
2009-07-03 9:32 ` Mark Brown [this message]
2009-07-03 10:15 ` Lars-Peter Clausen
2009-07-03 10:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703093250.GA29130@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.