All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] OMAP3 Fix compiler warning for v7_flush_dcache_all
Date: Fri, 3 Jul 2009 23:00:22 +0200	[thread overview]
Message-ID: <20090703210022.GC4937@game.jcrosoft.org> (raw)
In-Reply-To: <4A4D2D05.1080508@windriver.com>

On 16:56 Thu 02 Jul     , Tom wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> >On 15:04 Tue 30 Jun     , Tom Rix wrote:
> >>On build of omap3 targets in MAKEALL, the *.ERR files have
> >>
> >>cpu.c: In function 'cleanup_before_linux':
> >>cpu.c:64: warning: implicit declaration of function 'v7_flush_dcache_all'
> >>cpu.c:64: warning: implicit declaration of function 'get_device_type
> >>
> >>The functions v7_flush_dcache_all and get_device_type are declared
> >>in include/asm-arm/arch-omap3/sys_proto.h, so use this file to
> >>declare the functions.
> >>
> >>Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> >>---
> >> cpu/arm_cortexa8/cpu.c |    3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >>diff --git a/cpu/arm_cortexa8/cpu.c b/cpu/arm_cortexa8/cpu.c
> >>index fcb5775..ab1cfc7 100644
> >>--- a/cpu/arm_cortexa8/cpu.c
> >>+++ b/cpu/arm_cortexa8/cpu.c
> >>@@ -35,6 +35,9 @@
> >> #include <command.h>
> >> #include <asm/system.h>
> >> #include <asm/cache.h>
> >>+#ifndef CONFIG_L2_OFF
> >>+#include <asm/arch/sys_proto.h>
> >>+#endif
> >v7_flush_dcache_all is not omap3 specific but armv7 specific so we must no
> >need to depend on arch specific header
> >
> That is where they are declared.
> Would you rather the declaration be moved from sys_proto.h or to
> declare them in cpu.c ?
remove this non needed dependency
and use the generic flush dcache

Best Regards,
J.

  reply	other threads:[~2009-07-03 21:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 20:04 [U-Boot] Omap3 fix compiler warnings Tom Rix
2009-06-30 20:04 ` [U-Boot] [PATCH 1/1] OMAP3 Fix compiler warning for v7_flush_dcache_all Tom Rix
2009-07-02 21:00   ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-02 21:56     ` Tom
2009-07-03 21:00       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-07-04 12:41         ` Tom
2009-07-04 14:44           ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-05  7:21           ` Dirk Behme
2009-07-18 20:36   ` Wolfgang Denk
2009-07-19  6:25     ` Dirk Behme
2009-07-19  8:55       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090703210022.GC4937@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.