From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MNBXy-0005M7-7c for mharc-grub-devel@gnu.org; Sat, 04 Jul 2009 16:09:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNBXv-0005JL-U4 for grub-devel@gnu.org; Sat, 04 Jul 2009 16:09:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNBXr-0005Id-T2 for grub-devel@gnu.org; Sat, 04 Jul 2009 16:09:15 -0400 Received: from [199.232.76.173] (port=33105 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNBXr-0005Ia-Pd for grub-devel@gnu.org; Sat, 04 Jul 2009 16:09:11 -0400 Received: from aybabtu.com ([69.60.117.155]:39113) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MNBXr-0005v4-DB for grub-devel@gnu.org; Sat, 04 Jul 2009 16:09:11 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MNATj-00068D-9Y for grub-devel@gnu.org; Sat, 04 Jul 2009 21:00:51 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MNBXo-0006iP-7E for grub-devel@gnu.org; Sat, 04 Jul 2009 22:09:08 +0200 Date: Sat, 4 Jul 2009 22:09:08 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090704200908.GA27480@thorin> References: <1241620317.3746.8.camel@fz.local> <1243885166.3417.11.camel@fz.local> <1246458805.3454.1.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246458805.3454.1.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: grub-install --root-directory=/mnt /dev/sda1 fails X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2009 20:09:16 -0000 On Wed, Jul 01, 2009 at 04:33:25PM +0200, Felix Zielcke wrote: > Am Montag, den 01.06.2009, 21:39 +0200 schrieb Felix Zielcke: > > Am Mittwoch, den 06.05.2009, 17:12 +0200 schrieb Vladimir 'phcoder' > > Serbinenko: > > > Don't we already have a function which transforms host directory into > > > grub > > > directory? AFAIR we have. > > > > There's just the shell function in grub-mkconfig_lib.in > > Here's now a patch wich implements it in util/hostdisk.c and gets used > > for core_path_dev in setup (). > > But it doestn't work with symlinks. > > readlink () can only be used if the file pointed to is a symlink, not if > > a symlink is somewhere in between. > > coreutils where the readlink binary is from is GPL 3+ but the function > > for it uses hash tables and it seems like it would be too much code to > > copy just for this. > > So what do we do know about this problem? > We could just assume that the directory given with grub-setup > --directory is already the real absolute path and just use the stat > magic to make it relative. > Or we use realpath() if avaible to get the real one. > And on systems not having it, like mingw we could just assume that it's > already relative and just return the path given. > Or is there some other way this bug can be fixed? I just looked into this, and I don't think there's any real problem that needs fixing. The "workaround" is just a red herring, it works for him by pure chance. See: http://savannah.gnu.org/bugs/index.php?26924 -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."