From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MNBYj-0005pD-Cq for mharc-grub-devel@gnu.org; Sat, 04 Jul 2009 16:10:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNBYh-0005p5-RJ for grub-devel@gnu.org; Sat, 04 Jul 2009 16:10:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNBYc-0005om-Fq for grub-devel@gnu.org; Sat, 04 Jul 2009 16:10:02 -0400 Received: from [199.232.76.173] (port=56127 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNBYc-0005oj-Ac for grub-devel@gnu.org; Sat, 04 Jul 2009 16:09:58 -0400 Received: from aybabtu.com ([69.60.117.155]:59488) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MNBYb-0006AJ-RG for grub-devel@gnu.org; Sat, 04 Jul 2009 16:09:58 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MNAUU-00068M-8B for grub-devel@gnu.org; Sat, 04 Jul 2009 21:01:38 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MNBYZ-0006iW-8h for grub-devel@gnu.org; Sat, 04 Jul 2009 22:09:55 +0200 Date: Sat, 4 Jul 2009 22:09:55 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090704200955.GB27480@thorin> References: <20090701003502.25373.82948.stgit@mj.roinet.com> <20090701003509.25373.35314.stgit@mj.roinet.com> <20090701131025.GD17770@thorin> <20090701092049.0s8j20jmw0o8cggg-cebfxv@webmail.spamcop.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090701092049.0s8j20jmw0o8cggg-cebfxv@webmail.spamcop.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2009 20:10:03 -0000 On Wed, Jul 01, 2009 at 09:20:49AM -0400, Pavel Roskin wrote: > Quoting Robert Millan : > >> On Tue, Jun 30, 2009 at 08:35:09PM -0400, Pavel Roskin wrote: >>> + if (modlist != "") { >> >> Are you sure this does what you expect? I read it as "compare this >> char * with this const char *", which will always return false. > > Yes, this check does the right thing. And we do the same thing elsewhere: > > if (depmod != "kernel" && depmod != mod) > > Even the gawk info page has it: Oh, I thought you were writing C. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."