From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
Date: Sun, 5 Jul 2009 22:47:36 +0300 [thread overview]
Message-ID: <20090705194735.GB4043@redhat.com> (raw)
In-Reply-To: <20090705104516.GA1555@miranda.arrow>
On Sun, Jul 05, 2009 at 11:45:17AM +0100, Stuart Brady wrote:
> On Sun, Jul 05, 2009 at 01:24:24PM +0300, Michael S. Tsirkin wrote:
> > + if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> > + return;
>
> Same bug as fixed by 98846d7 ('Fix Sparse warning').
>
> Should be:
>
> if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
> return;
> }
>
> Cheers,
BTW what's the command to run sparse on qemu?
--
MST
next prev parent reply other threads:[~2009-07-05 19:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1246782566.git.mst@redhat.com>
2009-07-05 10:24 ` [PATCHv3 1/3] qemu/msi: fix segfault in msix_save Michael S. Tsirkin
2009-07-05 10:24 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 10:45 ` Stuart Brady
2009-07-05 19:47 ` Michael S. Tsirkin [this message]
2009-07-05 20:12 ` Blue Swirl
2009-07-05 10:46 ` Blue Swirl
2009-07-05 10:46 ` Blue Swirl
2009-07-05 11:10 ` Michael S. Tsirkin
2009-07-05 11:10 ` Michael S. Tsirkin
2009-07-05 10:24 ` [PATCHv3 2/3] qemu/virtio: remove control vector save Michael S. Tsirkin
2009-07-05 10:24 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 10:24 ` [PATCHv3 3/3] qemu/virtio: mark msi vectors used on load Michael S. Tsirkin
2009-07-05 10:24 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705194735.GB4043@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sdbrady@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.