From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] Fix xentop on pv-ops domain0
Date: Mon, 6 Jul 2009 15:34:31 +0200
Message-ID: <200907061534.31677.Christoph.Egger@amd.com>
References: <EADF0A36011179459010BDF5142A457501C9F46DA5@pdsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <EADF0A36011179459010BDF5142A457501C9F46DA5@pdsmsx502.ccr.corp.intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: "Xu, Dongxiao" <dongxiao.xu@intel.com>, "keir.fraser@eu.citrix.com" <keir.fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Monday 06 July 2009 15:08:06 Xu, Dongxiao wrote:
> Xentop encounters error in pv-ops domain0, because the VBD path in sysfs
> changes to "/sys/devices" Also delete the macro in xenstat_netbsd.c,
> because it is not used.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>

Can you move the Linux specific code you add in xentop.c into xenstat_linux.c, 
please? This is an abstraction violation, otherwise.

Thanks,
Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632