From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] Fix xentop on pv-ops domain0 Date: Mon, 6 Jul 2009 17:49:29 +0200 Message-ID: <200907061749.29633.Christoph.Egger@amd.com> References: <200907061534.31677.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Xu, Dongxiao" Cc: "xen-devel@lists.xensource.com" , "keir.fraser@eu.citrix.com" List-Id: xen-devel@lists.xenproject.org This patch is good. Christoph On Monday 06 July 2009 16:08:10 Xu, Dongxiao wrote: > Thanks for comments. The revised patch is attached! > > Best Regards, > -- Dongxiao > > -----Original Message----- > From: Christoph Egger [mailto:Christoph.Egger@amd.com] > Sent: Monday, July 06, 2009 9:35 PM > To: xen-devel@lists.xensource.com > Cc: Xu, Dongxiao; keir.fraser@eu.citrix.com > Subject: Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0 > > On Monday 06 July 2009 15:08:06 Xu, Dongxiao wrote: > > Xentop encounters error in pv-ops domain0, because the VBD path in sysfs > > changes to "/sys/devices" Also delete the macro in xenstat_netbsd.c, > > because it is not used. > > > > Signed-off-by: Dongxiao Xu > > Can you move the Linux specific code you add in xentop.c into > xenstat_linux.c, please? This is an abstraction violation, otherwise. > > Thanks, > Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632