From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: linux-next: block tree build failure Date: Tue, 7 Jul 2009 08:38:46 +0200 Message-ID: <20090707063846.GY23611@kernel.dk> References: <20090707134908.e81b1556.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from brick.kernel.dk ([93.163.65.50]:43748 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475AbZGGGin (ORCPT ); Tue, 7 Jul 2009 02:38:43 -0400 Content-Disposition: inline In-Reply-To: <20090707134908.e81b1556.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, "Zhang, Yanmin" On Tue, Jul 07 2009, Stephen Rothwell wrote: > Hi Jens, > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > fs/sync.c: In function 'sys_sync': > fs/sync.c:121: error: implicit declaration of function 'wakeup_pdflush' > > Caused by commit 1728603e84b339be5d5abd392ed3ec5936253863 ("writeback: > switch to per-bdi threads for flushing data") from the block tree > interacting with commit 3beab0b42413e83a7907db7176b54c840fc75a81 > ("sys_sync(): fix 16% performance regression in ffsb create_4k test") > from Linus' tree. > > I added the following patch as part of the block tree merge for today. I > have no idea if it is correct. > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > > From: Stephen Rothwell > Date: Tue, 7 Jul 2009 13:34:26 +1000 > Subject: [PATCH] block: pdflush fixup > > Signed-off-by: Stephen Rothwell > --- > fs/sync.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/sync.c b/fs/sync.c > index 3422ba6..bf03fc7 100644 > --- a/fs/sync.c > +++ b/fs/sync.c > @@ -118,7 +118,7 @@ restart: > */ > SYSCALL_DEFINE0(sync) > { > - wakeup_pdflush(0); > + wakeup_flusher_threads(0); > sync_filesystems(0); > sync_filesystems(1); > if (unlikely(laptop_mode)) That is correct! I have just now updated for-next as well, so your next pull should lose this fixup. -- Jens Axboe