From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Parse SIM alpha fields (EF-SPN) according to TS 11.11.
Date: Tue, 07 Jul 2009 14:37:01 -0500 [thread overview]
Message-ID: <200907071437.02179.denkenz@gmail.com> (raw)
In-Reply-To: <fb249edb0907070604n14e0c858u688e063184d17aba@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
Hi,
> 2009/7/7 Denis Kenzior <denkenz@gmail.com>:
> > Your patch was a 'bit' inefficient, generating way too many function
> > calls.
>
> True, but in my defense only in the paths we are unlikely to hit.
Well we don't really know that, so lets keep the code efficient whenever
possible ;)
>
> > I've pushed my own version called sim_string_to_utf8, which can be found
> > in util.c.
> >
> > Please review it for any issues..
>
> Looks correct to me, assuming there are no valid UCS2-BE characters
> with 0xff in first byte because the length check only checks first
> byte. The 0x81, 0x82 cases now also accept UTF-16 characters that
> aren't UCS-2 (with upper byte 0xd8...0xdf).
Both valid points, I've pushed fixes to both.
Regards,
-Denis
prev parent reply other threads:[~2009-07-07 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 3:14 [PATCH] Parse SIM alpha fields (EF-SPN) according to TS 11.11 Andrzej Zaborowski
2009-07-07 0:42 ` Denis Kenzior
2009-07-07 13:04 ` Andrzej Zaborowski
2009-07-07 19:37 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907071437.02179.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.