From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 1/2] ppc vdso: make sure rc is defined Date: Tue, 7 Jul 2009 15:58:30 -0500 Message-ID: <20090707205830.GA24752@us.ibm.com> References: <20090706233425.GA3186@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Nathan Lynch Cc: Linux Containers , Alexey Dobriyan List-Id: containers.vger.kernel.org Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org): > "Serge E. Hallyn" writes: > > Signed-off-by: Serge Hallyn > > --- > > arch/powerpc/kernel/vdso.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c > > index 48beff6..679b394 100644 > > --- a/arch/powerpc/kernel/vdso.c > > +++ b/arch/powerpc/kernel/vdso.c > > @@ -240,8 +240,10 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, > > } > > > > /* for restart(2), double check that we got we asked for */ > > - if (start && vdso_base != start) > > + if (start && vdso_base != start) { > > + rc = -EBUSY; > > goto fail_mmapsem; > > + } > > > > /* > > * our vma flags don't have VM_WRITE so by default, the process isn't > > Is this why you sent this patch? > > cc1: warnings being treated as errors > arch/powerpc/kernel/vdso.c: In function arch_setup_additional_pages: > arch/powerpc/kernel/vdso.c:194: error: rc may be used uninitialized in this function Yup. > If so, looks fine to me. -serge