From: Wu Fengguang <fengguang.wu@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Wu Fengguang <fengguang.wu@intel.com>
Subject: [PATCH 4/4] alsa-info.sh: introduce withall()
Date: Wed, 08 Jul 2009 21:07:26 +0800 [thread overview]
Message-ID: <20090708131504.317462072@intel.com> (raw)
In-Reply-To: 20090708130722.723912338@intel.com
[-- Attachment #1: alsa-de-duplicate.patch --]
[-- Type: text/plain, Size: 2090 bytes --]
This merges duplicate code. The only behavior change is, we will now call
withsysfs() when no options are provided. I guess this is desired info.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
utils/alsa-info.sh | 64 +++++++++++--------------------------------
1 file changed, 17 insertions(+), 47 deletions(-)
--- alsa-driver.orig/utils/alsa-info.sh
+++ alsa-driver/utils/alsa-info.sh
@@ -243,6 +243,16 @@ withsysfs() {
fi
}
+withall() {
+ withdevices
+ withconfigs
+ withaplay
+ withamixer
+ withalsactl
+ withlsmod
+ withsysfs
+}
+
get_alsa_library_version() {
ALSA_LIB_VERSION=`grep VERSION_STR /usr/include/alsa/version.h 2>/dev/null|awk {'print $3'}|sed 's/"//g'`
@@ -559,12 +569,7 @@ fi
if [[ -z "$1" ]]
then
update
- withdevices
- withconfigs
- withaplay
- withamixer
- withalsactl
- withlsmod
+ withall
pbcheck
fi
@@ -578,13 +583,7 @@ then
case "$1" in
--pastebin)
update
- withdevices
- withconfigs
- withaplay
- withamixer
- withalsactl
- withlsmod
- withsysfs
+ withall
pbcheck
;;
--update)
@@ -593,44 +592,20 @@ then
;;
--upload)
UPLOAD="yes"
- withdevices
- withconfigs
- withaplay
- withamixer
- withalsactl
- withlsmod
- withsysfs
+ withall
;;
--no-upload)
UPLOAD="no"
- withdevices
- withconfigs
- withaplay
- withamixer
- withalsactl
- withlsmod
- withsysfs
+ withall
;;
--debug)
echo "Debugging enabled. $FILE and $TEMPDIR will not be deleted"
KEEP_FILES="yes"
echo ""
- withdevices
- withconfigs
- withaplay
- withamixer
- withalsactl
- withlsmod
- withsysfs
+ withall
;;
--with-all)
- withdevices
- withconfigs
- withaplay
- withamixer
- withalsactl
- withlsmod
- withsysfs
+ withall
;;
--with-aplay)
withaplay
@@ -674,12 +649,7 @@ then
;;
--stdout)
UPLOAD="no"
- withdevices
- withconfigs
- withaplay
- withamixer
- withalsactl
- withlsmod
+ withall
cat $FILE
rm $FILE
;;
--
next prev parent reply other threads:[~2009-07-08 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 13:07 [PATCH 0/4] alsa-info.sh updates Wu Fengguang
2009-07-08 13:07 ` [PATCH 1/4] alsa-info.sh: Do not automatically upload alsa info Wu Fengguang
2009-07-08 13:25 ` Wu Fengguang
2009-07-08 13:07 ` [PATCH 2/4] alsa-info.sh: fix whitespace leaked to stdout Wu Fengguang
2009-07-08 13:07 ` [PATCH 3/4] alsa-info.sh: let mv fail loudly Wu Fengguang
2009-07-08 13:07 ` Wu Fengguang [this message]
2009-07-09 16:51 ` [PATCH 0/4] alsa-info.sh updates Takashi Iwai
2009-07-09 17:03 ` Daniel Chen
2009-07-09 17:19 ` Mark Brown
2009-07-16 9:42 ` Takashi Iwai
2009-07-16 11:24 ` [PATCH] alsa-info.sh: add dmesg info on ALSA/HDA Wu Fengguang
2009-07-16 11:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090708131504.317462072@intel.com \
--to=fengguang.wu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.