From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: James.Bottomley@HansenPartnership.com, dwalker@fifo99.com,
maciej.rutecki@gmail.com, akpm@linux-foundation.org,
tarkan.erimer@turknet.net.tr, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media
Date: Thu, 9 Jul 2009 09:50:04 +0200 [thread overview]
Message-ID: <20090709075004.GH23611@kernel.dk> (raw)
In-Reply-To: <20090709084839G.fujita.tomonori@lab.ntt.co.jp>
On Thu, Jul 09 2009, FUJITA Tomonori wrote:
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] block: call blk_scsi_ioctl_init()
>
> Currently, blk_scsi_ioctl_init() is not called so
> blk_default_cmd_filter isn't initalized. Some commands are not blocked
> wrongly.
>
> This fixes a regression introduced:
>
> commit 018e0446890661504783f92388ecce7138c1566d
> Author: Jens Axboe <jens.axboe@oracle.com>
> Date: Fri Jun 26 16:27:10 2009 +0200
>
> block: get rid of queue-private command filter
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
> block/scsi_ioctl.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> index f0e0ce0..e5b1001 100644
> --- a/block/scsi_ioctl.c
> +++ b/block/scsi_ioctl.c
> @@ -680,3 +680,4 @@ int __init blk_scsi_ioctl_init(void)
> blk_set_cmd_filter_defaults(&blk_default_cmd_filter);
> return 0;
> }
> +fs_initcall(blk_scsi_ioctl_init);
> --
> 1.6.0.6
You beat me to it, it was the missing call as I suspected. This
works, I verified it myself. Applied to for-linus, going upstream
soon.
--
Jens Axboe
next prev parent reply other threads:[~2009-07-09 7:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 13:23 [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media Tarkan Erimer
2009-07-02 20:07 ` Andrew Morton
2009-07-08 13:09 ` Maciej Rutecki
2009-07-08 14:27 ` James Bottomley
2009-07-08 16:06 ` Daniel Walker
2009-07-08 16:44 ` James Bottomley
2009-07-08 16:57 ` Jens Axboe
2009-07-08 23:49 ` FUJITA Tomonori
2009-07-08 23:54 ` FUJITA Tomonori
2009-07-09 6:27 ` Maciej Rutecki
2009-07-09 6:27 ` Maciej Rutecki
2009-07-09 7:50 ` Jens Axboe [this message]
2009-07-09 8:08 ` FUJITA Tomonori
2009-07-09 8:12 ` Jens Axboe
2009-07-08 18:22 ` Maciej Rutecki
2009-07-08 18:22 ` Maciej Rutecki
2009-07-08 22:52 ` Martin K. Petersen
2009-07-09 4:28 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709075004.GH23611@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=dwalker@fifo99.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=tarkan.erimer@turknet.net.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.