From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [Bug #13337] [post 2.6.29 regression] hang during suspend of b44/b43 modules Date: Thu, 9 Jul 2009 22:34:38 +0200 Message-ID: <200907092234.39663.rjw@sisk.pl> References: <200907092203.10294.rjw@sisk.pl> <1247171295.1905.5.camel@johannes.local> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1247171295.1905.5.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org> Content-Disposition: inline Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: Text/Plain; charset="us-ascii" To: Johannes Berg Cc: Jan Scholz , Linux Kernel Mailing List , Kernel Testers List , Tomas Janousek , "John W. Linville" On Thursday 09 July 2009, Johannes Berg wrote: > On Thu, 2009-07-09 at 22:03 +0200, Rafael J. Wysocki wrote: > > On Thursday 09 July 2009, Jan Scholz wrote: > > > Hi, > > > > > > I have just checked this on v2.6.31-rc1 and v2.6.31-rc2-214-g34f2547 > > > (I wanted to test this on v2.6.31-rc2 as well, but there I had other > > > suspend-issues that are fixed in todays v2.6.31-rc2-214-g34f2547) > > > > > > For both v2.6.31-rc1 and v2.6.31-rc2-214-g34f2547 suspend to ram fails > > > with the test procedure described below, but it works fine when I revert > > > commit 5bb644a0fd25a5e083ecbfaa92a211db99aa6ef7 > > > "mac80211: cancel/restart all timers across suspend/resume" > > > > Thanks for the update. > > > > Johannes, do you have any idea what can go wrong here? > > Not really, no. __ieee80211_suspend isn't holding any locks that the > cancel_work_sync() calls could require or so afaict... > > Jan, can you run with console_suspend=0 (or whatever it is now, Rafael > will correct me if I'm wrong) That's just 'no_console_suspend'. Best, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754980AbZGIUed (ORCPT ); Thu, 9 Jul 2009 16:34:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752892AbZGIUeZ (ORCPT ); Thu, 9 Jul 2009 16:34:25 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:47831 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754125AbZGIUeZ (ORCPT ); Thu, 9 Jul 2009 16:34:25 -0400 From: "Rafael J. Wysocki" To: Johannes Berg Subject: Re: [Bug #13337] [post 2.6.29 regression] hang during suspend of b44/b43 modules Date: Thu, 9 Jul 2009 22:34:38 +0200 User-Agent: KMail/1.11.2 (Linux/2.6.31-rc2-rjw; KDE/4.2.4; x86_64; ; ) Cc: Jan Scholz , Linux Kernel Mailing List , Kernel Testers List , Tomas Janousek , "John W. Linville" References: <200907092203.10294.rjw@sisk.pl> <1247171295.1905.5.camel@johannes.local> In-Reply-To: <1247171295.1905.5.camel@johannes.local> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907092234.39663.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 09 July 2009, Johannes Berg wrote: > On Thu, 2009-07-09 at 22:03 +0200, Rafael J. Wysocki wrote: > > On Thursday 09 July 2009, Jan Scholz wrote: > > > Hi, > > > > > > I have just checked this on v2.6.31-rc1 and v2.6.31-rc2-214-g34f2547 > > > (I wanted to test this on v2.6.31-rc2 as well, but there I had other > > > suspend-issues that are fixed in todays v2.6.31-rc2-214-g34f2547) > > > > > > For both v2.6.31-rc1 and v2.6.31-rc2-214-g34f2547 suspend to ram fails > > > with the test procedure described below, but it works fine when I revert > > > commit 5bb644a0fd25a5e083ecbfaa92a211db99aa6ef7 > > > "mac80211: cancel/restart all timers across suspend/resume" > > > > Thanks for the update. > > > > Johannes, do you have any idea what can go wrong here? > > Not really, no. __ieee80211_suspend isn't holding any locks that the > cancel_work_sync() calls could require or so afaict... > > Jan, can you run with console_suspend=0 (or whatever it is now, Rafael > will correct me if I'm wrong) That's just 'no_console_suspend'. Best, Rafael