From: Jens Axboe <jens.axboe@oracle.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Liu Hui <onlyflyer@gmail.com>, Yan Zheng <yanzheng@21cn.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Fix partial discard on RAID1
Date: Fri, 10 Jul 2009 07:14:36 +0200 [thread overview]
Message-ID: <20090710051436.GW23611@kernel.dk> (raw)
In-Reply-To: <1247180532.7423.5.camel@macbook.infradead.org>
On Fri, Jul 10 2009, David Woodhouse wrote:
> In btrfs_discard_extent() we were only discarding half of a RAID1 or
> RAID10 extent.
>
> We should be telling btrfs_map_block() that we want to write, so it
> tells us about _all_ mirrors. If we tell it we're going to read, it'll
> only tell us about a single mirror at a time.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
> ---
> Untested. Does anyone have any real devices that do TRIM yet, or do I
> need to hack up an FTL to do it again?
Get one of the OCZ vertex drives, they do trim. They use their own
opcode for it, but it's there.
--
Jens Axboe
next prev parent reply other threads:[~2009-07-10 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 15:23 [PATCH]Btrfs:Fix discard semantic Liu Hui
2009-01-01 12:57 ` Yan Zheng
2009-01-03 15:33 ` Liu Hui
2009-01-05 15:08 ` Chris Mason
2009-07-09 22:57 ` David Woodhouse
2009-07-09 23:02 ` [PATCH] btrfs: Fix partial discard on RAID1 David Woodhouse
2009-07-10 5:14 ` Jens Axboe [this message]
2009-07-11 10:29 ` [PATCH]Btrfs:Fix discard semantic David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090710051436.GW23611@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dwmw2@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=onlyflyer@gmail.com \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.