From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPG2K-0003nP-WC
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 09:21:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPG2F-0003hj-Cv
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 09:21:12 -0400
Received: from [199.232.76.173] (port=34804 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPG2E-0003hD-Tk
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 09:21:07 -0400
Received: from outbound-dub.frontbridge.com ([213.199.154.16]:2179
	helo=IE1EHSOBE004.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Christoph.Egger@amd.com>)
	id 1MPG2E-0007mX-Dz
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 09:21:06 -0400
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64
Date: Fri, 10 Jul 2009 15:20:37 +0200
References: <200906301513.12043.Christoph.Egger@amd.com>
	<200907101019.31977.Christoph.Egger@amd.com>
	<4A573B08.9010903@codemonkey.ws>
In-Reply-To: <4A573B08.9010903@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200907101520.38417.Christoph.Egger@amd.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Friday 10 July 2009 14:58:48 Anthony Liguori wrote:
> Christoph Egger wrote:
> > On Thursday 09 July 2009 21:21:06 Anthony Liguori wrote:
> >> Christoph Egger wrote:
> >>> Hi!
> >>>
> >>> Attached patch fixes this build error on NetBSD/amd64:
> >>>
> >>> hw/xen_blkif.h:20: warning: #pragma pack(psuh[, id], <n>) is not
> >>> supported on this target
> >>> hw/xen_blkif.h:36: warning: #pragma pack(pop[, id], <n>) is not
> >>> supported on this target
> >>>
> >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> >>
> >> You'll invoke the fury of malc for introducing an identifier that begins
> >> with '__' :-)
> >
> > In NetBSD, there is this in <sys/cdefs.h> :
>
> NetBSD is allowed to use these names in system headers but according to
> the C standard, normal programs like QEMU aren't.  So we need to use
> something other than __aligned.

What about  __qemu_aligned ?

#ifdef __NetBSD__
#define __qemu_aligned(x)    __aligned(x)
#else
#define __qemu_aligned(x)    __attribute__((__aligned__(x)))
#endif


> Regards,
>
> Anthony Liguori



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632