From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MPJZx-0001Cr-PW for mharc-grub-devel@gnu.org; Fri, 10 Jul 2009 13:08:09 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPJZw-0001Cc-K2 for grub-devel@gnu.org; Fri, 10 Jul 2009 13:08:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPJZs-0001Am-44 for grub-devel@gnu.org; Fri, 10 Jul 2009 13:08:08 -0400 Received: from [199.232.76.173] (port=55870 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPJZr-0001Af-H4 for grub-devel@gnu.org; Fri, 10 Jul 2009 13:08:03 -0400 Received: from aybabtu.com ([69.60.117.155]:58627) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MPJZr-0000OK-3l for grub-devel@gnu.org; Fri, 10 Jul 2009 13:08:03 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MPIVA-0001pS-Ai for grub-devel@gnu.org; Fri, 10 Jul 2009 17:59:08 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MPJZn-0004Sx-6T for grub-devel@gnu.org; Fri, 10 Jul 2009 19:07:59 +0200 Date: Fri, 10 Jul 2009 19:07:59 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090710170759.GA17114@thorin> References: <20090627112521.GA28637@thorin> <20090707195153.GA10993@thorin> <1246999907.3393.43.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246999907.3393.43.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] use ljmp to reboot (Re: at_keyboard flush on i386-qemu) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2009 17:08:09 -0000 On Tue, Jul 07, 2009 at 04:51:47PM -0400, Pavel Roskin wrote: > On Tue, 2009-07-07 at 21:51 +0200, Robert Millan wrote: > > > I think we should just jump to 0xffff0 to reboot. I didn't know back when I > > wrote reboot.c, but this is supposedly more reliable since we're jumping to > > code in ROM which hasn't been overwritten (kern/i386/pc/startup.S uses the > > same trick for its own grub_reboot()). > > I have no objections about the patch except that it breaks compilation > for i386-coreboot: > > kernel_img-symlist.o:(.data+0x3b4): undefined reference to `grub_reboot' > > Perhaps kern/i386/reboot.c should be kept, but the code should only be > enabled for coreboot. Actually, coreboot has the same problem and should use the same approach (these two ports are almost identical). > By the way, GRUB_MACHINE_LINUXBIOS should be renamed to > GRUB_MACHINE_COREBOOT. Fine with me. Only lack of time prevents this :-) > Its use in loader/multiboot_loader.c is dubious. This should become "ifdef __i386__" someday. Unfortunately some things (e.g. mmap) associated with the multiboot loader are not portable. Ah, but GRUB_MACHINE_QEMU should be there too. This can be added already. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."