From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MPMZs-0005ew-7O for mharc-grub-devel@gnu.org; Fri, 10 Jul 2009 16:20:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPMZq-0005ej-KV for grub-devel@gnu.org; Fri, 10 Jul 2009 16:20:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPMZl-0005dy-Be for grub-devel@gnu.org; Fri, 10 Jul 2009 16:20:13 -0400 Received: from [199.232.76.173] (port=56360 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPMZl-0005du-7e for grub-devel@gnu.org; Fri, 10 Jul 2009 16:20:09 -0400 Received: from aybabtu.com ([69.60.117.155]:40721) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MPMZk-0004NY-Ro for grub-devel@gnu.org; Fri, 10 Jul 2009 16:20:09 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MPLV4-0002Jg-Hm for grub-devel@gnu.org; Fri, 10 Jul 2009 21:11:15 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MPMZi-00066l-6q for grub-devel@gnu.org; Fri, 10 Jul 2009 22:20:06 +0200 Date: Fri, 10 Jul 2009 22:20:06 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090710202006.GA23349@thorin> References: <20090709160301.GA29422@thorin> <20090710174115.GI17114@thorin> <20090710.111828.59251298.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090710.111828.59251298.davem@davemloft.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: OLPC regression, ofdisk stops working X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2009 20:20:15 -0000 On Fri, Jul 10, 2009 at 11:18:28AM -0700, David Miller wrote: > From: Robert Millan > Date: Fri, 10 Jul 2009 19:41:15 +0200 > > > On Fri, Jul 10, 2009 at 10:28:03PM +0800, Bean wrote: > >> Hi, > >> > >> There is something wrong with r2132, now childtype is a pointer, so > >> sizeof childtype == 4, the name would be truncated to 4 characters. > > > > Bean, you never cease to amaze me. I admit the "interesting, exactly > > the word size" idea crossed my head, but I didn't reach any conclussion > > out of it :-) > > > > Nice catch. Will you commit this, or want me to? > > Good catch, I thought I had gotten all of those size > conversions correct, guess not :-/ Don't worry about it, shit happens. Btw, I just committed it. I found another instance of the same problem in that file, which I fixed as well. Thanks a lot Bean! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."