Re: [PATCH / RESENT #3] mtd: let include/linux/mtd/partitions.h stand on its own

From: Florian Fainelli <florian@openwrt.org>
To: linux-mtd@lists.infradead.org
Cc: Nicolas Pitre <nico@cam.org>, Martin Michlmayr <tbm@cyrius.com>
Subject: Re: [PATCH / RESENT #3] mtd: let include/linux/mtd/partitions.h stand on its own
Date: Fri, 10 Jul 2009 21:34:45 +0200	[thread overview]
Message-ID: <200907102134.46212.florian@openwrt.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0907101448360.3138@xanadu.home>

Hi Nicolas,

Le Friday 10 July 2009 20:51:33 Nicolas Pitre, vous avez écrit :
> When declaring static MTD partitions in board specific code, only
> including include/linux/mtd/partitions.h should suffice without
> gcc nagging us with:
>
> In file included from arch/arm/mach-kirkwood/sheevaplug-setup.c:14:
> include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared
> inside parameter list include/linux/mtd/partitions.h:50: warning: its scope
> is only this definition or declaration, which is probably not what you want
> include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared
> inside parameter list include/linux/mtd/partitions.h:61: warning: 'struct
> mtd_info' declared inside parameter list include/linux/mtd/partitions.h:67:
> warning: 'struct mtd_info' declared inside parameter list
>
> Signed-off-by: Nicolas Pitre <nico@marvell.com>

Thanks for doing this, Martin and I had the same problem on Cobalt Microservers (MIPS).

> ---
>
> Hello?  Anybody home?
>
> diff --git a/include/linux/mtd/partitions.h
> b/include/linux/mtd/partitions.h index af6dcb9..b70313d 100644
> --- a/include/linux/mtd/partitions.h
> +++ b/include/linux/mtd/partitions.h
> @@ -47,6 +47,8 @@ struct mtd_partition {
>  #define MTDPART_SIZ_FULL	(0)
>
>
> +struct mtd_info;
> +
>  int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *,
> int); int del_mtd_partitions(struct mtd_info *);
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------