From: Arjan van de Ven <arjan@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ingo Molnar <mingo@elte.hu>,
Siarhei Liakh <sliakh.lkml@gmail.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
James Morris <jmorris@namei.org>,
Andrew Morton <akpm@linux-foundation.org>, Andi Kleen <ak@muc.de>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v5] RO/NX protection for loadable kernel modules
Date: Sat, 11 Jul 2009 08:49:58 -0700 [thread overview]
Message-ID: <20090711084958.69ff9196@infradead.org> (raw)
In-Reply-To: <200907111821.47769.rusty@rustcorp.com.au>
On Sat, 11 Jul 2009 18:21:46 +0930
Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Sat, 11 Jul 2009 03:37:01 pm Rusty Russell wrote:
> > On Fri, 10 Jul 2009 08:54:03 pm Ingo Molnar wrote:
> > > please use the customary comment style:
> >
> > Please don't. There's one spot in that file which does it, and
> > frankly it's a distracting waste of space.
>
> Sorry, Ingo there's more than one. I don't bother fixing up others'
> comments in patches, so the file is now a bit mixed. It'd be better
> to make it uniform, in which case I'd change it to kernel-style.
>
> I have a question about this patch though: I think it's unsafe in
> general to mark the last partial page as NX (we asked for executable
> pages, this could remove executable from some unrelated allocation).
>
we vmalloc / g_f_p modules right? so we don't share the last page.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-07-11 15:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 23:10 [PATCH v5] RO/NX protection for loadable kernel modules Siarhei Liakh
[not found] ` <20090710112403.GC3760@elte.hu>
[not found] ` <200907111537.03191.rusty@rustcorp.com.au>
2009-07-11 7:30 ` Ingo Molnar
2009-07-11 11:22 ` Rusty Russell
2009-07-11 8:51 ` Rusty Russell
2009-07-11 15:49 ` Arjan van de Ven [this message]
2009-07-12 4:40 ` Rusty Russell
2009-07-12 4:45 ` H. Peter Anvin
2009-07-12 7:45 ` Arjan van de Ven
2009-07-12 9:25 ` Andi Kleen
2009-07-12 9:58 ` Rusty Russell
2009-07-12 15:32 ` Arjan van de Ven
2009-07-12 17:33 ` Greg KH
2009-07-12 21:58 ` Arjan van de Ven
2009-07-12 22:14 ` Greg KH
2009-07-13 9:02 ` Andi Kleen
2009-07-12 23:21 ` Rusty Russell
2009-07-13 3:11 ` Arjan van de Ven
2009-07-12 9:24 ` Andi Kleen
2009-07-13 16:59 ` Roland Dreier
2009-07-13 10:59 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090711084958.69ff9196@infradead.org \
--to=arjan@infradead.org \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sliakh.lkml@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.