From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MPhhJ-0005qD-OP for mharc-grub-devel@gnu.org; Sat, 11 Jul 2009 14:53:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPhhH-0005pr-Mw for grub-devel@gnu.org; Sat, 11 Jul 2009 14:53:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPhhC-0005no-Br for grub-devel@gnu.org; Sat, 11 Jul 2009 14:53:18 -0400 Received: from [199.232.76.173] (port=32954 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPhhC-0005nd-6r for grub-devel@gnu.org; Sat, 11 Jul 2009 14:53:14 -0400 Received: from aybabtu.com ([69.60.117.155]:39431) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MPhhB-0004rD-OB for grub-devel@gnu.org; Sat, 11 Jul 2009 14:53:13 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MPgcP-0007yq-L2 for grub-devel@gnu.org; Sat, 11 Jul 2009 19:44:14 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MPhh8-0008Vx-Mh for grub-devel@gnu.org; Sat, 11 Jul 2009 20:53:10 +0200 Date: Sat, 11 Jul 2009 20:53:10 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090711185310.GC18506@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] hidemenu fix X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2009 18:53:19 -0000 On Sat, Jul 11, 2009 at 01:26:50PM +0800, Bean wrote: > Hi, > > This patch moves the screen init code from reader to menu, so that > hidemenu would work as before. A minor side effect is that if grub.cfg > is not found, the "GNU GRUB" header would not be printed, but I guess > this is not an issue. Hi Bean, I don't understand this very well. First of all, which part is supposed to be responsible for printing the header? Are you changing that? Right now it is being printed twice. > -static grub_err_t > -grub_rescue_init (void) > -{ > - grub_printf ("Entering rescue mode...\n"); > - return 0; > -} > - > /* Prompt to input a command and read the line. */ > static grub_err_t > grub_rescue_read_line (char **line, int cont) > @@ -77,7 +70,6 @@ grub_rescue_read_line (char **line, int cont) > static struct grub_reader grub_rescue_reader = > { > .name = "rescue", > - .init = grub_rescue_init, > .read_line = grub_rescue_read_line > }; Why is grub_rescue_init being removed? > @@ -524,7 +517,6 @@ grub_normal_read_line (char **line, int cont) > static struct grub_reader grub_normal_reader = > { > .name = "normal", > - .init = grub_normal_reader_init, > .read_line = grub_normal_read_line > }; And this one, too. If readers are no longer responsible for printing a header, shouldn't we adjust whatever code that was calling their init functions, and the grub_reader struct as well? This patch looks like a kludge to me. Can we discuss what's wrong with the current design, and what options do we have to solve this? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."