All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] gdb-xml: fix hacks in powerpc register numbering
Date: Sun, 12 Jul 2009 23:42:38 +0200	[thread overview]
Message-ID: <20090712214238.GC28418@volta.aurel32.net> (raw)
In-Reply-To: <1244167348-806-1-git-send-email-froydnj@codesourcery.com>

On Thu, Jun 04, 2009 at 07:02:28PM -0700, Nathan Froyd wrote:
> The powerpc xml files contained a hack--an empty, non-existent
> register--for getting the register numbers to line up for
> newer (XML-aware) and older (non-XML-aware) GDB.  While this hack worked
> in some cases, it didn't work in all cases, notably when the user used
> `finish' or `continue': GDB would attempt to read the non-existent
> register and QEMU would complain.
> 
> This patch fixes things up properly.  Instead of inserting a fake
> register, we explicitly declare the floating-point and SPE registers to
> start at 71.  This action accomplishes the same thing as the nasty hack,
> except that now GDB never tries to fetch the non-existant register 70.

Thanks, applied.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      parent reply	other threads:[~2009-07-12 21:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05  2:02 [Qemu-devel] [PATCH] gdb-xml: fix hacks in powerpc register numbering Nathan Froyd
2009-06-23 15:35 ` Nathan Froyd
2009-07-07 16:04 ` Nathan Froyd
2009-07-12 21:42 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090712214238.GC28418@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=froydnj@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.