From: Theodore Tso <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd2: Fix a race between checkpointing code and journal_get_write_access()
Date: Mon, 13 Jul 2009 09:19:01 -0400 [thread overview]
Message-ID: <20090713131901.GC12833@mit.edu> (raw)
In-Reply-To: <20090710100713.GB17524@duck.suse.cz>
On Fri, Jul 10, 2009 at 12:07:13PM +0200, Jan Kara wrote:
> Yes, it should be "this should never happen", unless you run something
> like tune2fs while the filesystem is mounted. But looking at the code, I
> have missed that buffer could be dirty also in
> jbd2_journal_get_create_access() because jbd2_journal_forget() does not
> clear the dirty bit in case the buffer is just being committed. Attached
> patch should fix it. Thanks for report.
Thanks, added to the patch queue.
- Ted
next prev parent reply other threads:[~2009-07-13 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 16:02 [PATCH] jbd: Fix a race between checkpointing code and journal_get_write_access() Jan Kara
2009-06-24 16:02 ` [PATCH] jbd2: " Jan Kara
2009-07-06 2:53 ` Theodore Tso
2009-07-08 22:31 ` Theodore Tso
2009-07-10 10:07 ` Jan Kara
2009-07-13 13:19 ` Theodore Tso [this message]
2009-07-13 13:29 ` Jan Kara
2009-07-13 14:44 ` Theodore Tso
2009-07-13 15:29 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713131901.GC12833@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.