Re: [PATCH] brtfs: less- and greater than confusion

[Chris Mason <chris.mason@oracle.com>]

[ sorry, fixed up cc ]

On Mon, Jul 13, 2009 at 09:22:52AM -0400, Chris Mason wrote:
> On Mon, Jul 13, 2009 at 12:30:48AM +0200, Roel Kluin wrote:
> > Without this the loop won't start
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> > index 3ab80e9..2c873c9 100644
> > --- a/fs/btrfs/volumes.c
> > +++ b/fs/btrfs/volumes.c
> > @@ -2795,7 +2795,7 @@ int btrfs_rmap_block(struct btrfs_mapping_tree *map_tree,
> >  		}
> >  	}
> >  
> > -	for (i = 0; i > nr; i++) {
> > +	for (i = 0; i < nr; i++) {
> >  		struct btrfs_multi_bio *multi;
> >  		struct btrfs_bio_stripe *stripe;
> >  		int ret;
> 
> Thanks, this does look buggy.  That second loop should just be to verify
> the first loop didn't mess things up.  Yan Zheng, is there any reason we
> shouldn't delete it?
> 
> -chris
>