From: Theodore Tso <tytso@mit.edu>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] fix null handler of ioctls in no journal mode
Date: Mon, 13 Jul 2009 09:29:53 -0400 [thread overview]
Message-ID: <20090713132953.GA1030@mit.edu> (raw)
In-Reply-To: <1247223826-24378-1-git-send-email-bergwolf@gmail.com>
On Fri, Jul 10, 2009 at 07:03:46PM +0800, Peng Tao wrote:
> EXT4_IOC_GROUP_ADD and EXT4_IOC_GROUP_EXTEND ioctls should not flush journal
> in no_journal mode.
Thanks, added to the ext4 patch queue, altough I did tighten up up
your patch description slightly:
ext4: fix null handler of ioctls in no journal mode
The EXT4_IOC_GROUP_ADD and EXT4_IOC_GROUP_EXTEND ioctls should not
flush the journal in no_journal mode. Otherwise, running resize2fs on
a mounted no_journal partition triggers the following error messages:
BUG: unable to handle kernel NULL pointer dereference at 00000014
IP: [<c039d282>] _spin_lock+0x8/0x19
*pde = 00000000
Oops: 0002 [#1] SMP
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
- Ted
prev parent reply other threads:[~2009-07-13 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 11:03 [PATCH] fix null handler of ioctls in no journal mode Peng Tao
2009-07-13 13:29 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713132953.GA1030@mit.edu \
--to=tytso@mit.edu \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.