From: Oleg Nesterov <oleg@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: David Howells <dhowells@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Roland McGrath <roland@redhat.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -mm 2/2] current_is_single_threaded: don't use ->mmap_sem
Date: Tue, 14 Jul 2009 01:56:12 +0200 [thread overview]
Message-ID: <20090713235612.GA4361@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.00.0907130811380.29074@tundra.namei.org>
On 07/13, James Morris wrote:
>
> On Fri, 10 Jul 2009, David Howells wrote:
>
> > > However we can avoid ->mmap_sem and rely on rcu/barriers:
> > >
> > > - if we do not see the exiting parent on thread/process list
> > > we see the result of list_del_rcu(), in this case we must
> > > also see the result of list_add_rcu() which does wmb().
> > >
> > > - if we do see the parent but its ->mm == NULL, we need rmb()
> > > to make sure we can't miss the child.
> > >
> > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> >
> > Acked-by: David Howells <dhowells@redhat.com>
>
> I gather this stuff is going into -mm ?
Yes, this is on top of rework-fix-is_single_threaded.patch
Given that David acked these changes, I guess they will go
to -mm soon.
> Can it be merged via security-testing#next?
Please do what you think right, I don't know what will be more
convenient to you and Andrew.
Oleg.
next prev parent reply other threads:[~2009-07-13 23:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 21:28 [PATCH -mm 1/2] rename is_single_threaded(task) to is_current_single_threaded(void) Oleg Nesterov
2009-07-09 23:04 ` James Morris
2009-07-10 1:33 ` Christoph Hellwig
2009-07-10 1:46 ` Oleg Nesterov
2009-07-10 1:48 ` [PATCH v2 -mm 1/2] rename is_single_threaded(task) to current_is_single_threaded(void) Oleg Nesterov
2009-07-10 14:07 ` David Howells
2009-07-10 1:48 ` [PATCH v2 -mm 2/2] current_is_single_threaded: don't use ->mmap_sem Oleg Nesterov
2009-07-10 14:07 ` David Howells
2009-07-12 22:12 ` James Morris
2009-07-13 23:56 ` Oleg Nesterov [this message]
2009-07-16 23:41 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713235612.GA4361@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=roland@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.