All of lore.kernel.org
 help / color / mirror / Atom feed
From: wysochanski@sourceware.org <wysochanski@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/liblvm lvm_base.c
Date: 14 Jul 2009 03:01:18 -0000	[thread overview]
Message-ID: <20090714030118.5342.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski at sourceware.org	2009-07-14 03:01:18

Modified files:
	liblvm         : lvm_base.c 

Log message:
	Add default cmd->cmd_line initialization for liblvm lvm_create().
	
	This needs initialized to non-NULL before using the archive() call.
	Normally this is set to the cmdline string when lvm is called from a tool.
	We could think about using it in another way, as a potential audit trail
	of liblvm calls, or just leave it set to the default "liblvm", similar to
	what clvmd does.  For now, just set it to "liblvm".
	
	Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
	Acked-by: Alasdair G Kergon <agk@redhat.com>

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/liblvm/lvm_base.c.diff?cvsroot=lvm2&r1=1.2&r2=1.3

--- LVM2/liblvm/lvm_base.c	2009/03/10 15:38:46	1.2
+++ LVM2/liblvm/lvm_base.c	2009/07/14 03:01:18	1.3
@@ -45,6 +45,12 @@
 		lvm_destroy((lvm_t) cmd);
 		return NULL;
 	}
+	/*
+	 * FIXME: Use cmd->cmd_line as audit trail for liblvm calls.  Used in
+	 * archive() call.  Possible example:
+	 * cmd_line = "lvm_vg_create: vg1\nlvm_vg_extend vg1 /dev/sda1\n"
+	 */
+	cmd->cmd_line = (char *)"liblvm";
 
 	return (lvm_t) cmd;
 }



             reply	other threads:[~2009-07-14  3:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14  3:01 wysochanski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-05-19 12:12 LVM2/liblvm lvm_base.c wysochanski
2009-07-27 21:02 wysochanski
2009-03-10 15:38 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090714030118.5342.qmail@sourceware.org \
    --to=wysochanski@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.