From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MQlwM-0001YD-1c for mharc-grub-devel@gnu.org; Tue, 14 Jul 2009 13:37:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MQlwK-0001Y8-W8 for grub-devel@gnu.org; Tue, 14 Jul 2009 13:37:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MQlwG-0001Xw-IS for grub-devel@gnu.org; Tue, 14 Jul 2009 13:37:16 -0400 Received: from [199.232.76.173] (port=42069 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQlwG-0001Xt-DU for grub-devel@gnu.org; Tue, 14 Jul 2009 13:37:12 -0400 Received: from mx20.gnu.org ([199.232.41.8]:22690) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MQlwG-0002bX-0u for grub-devel@gnu.org; Tue, 14 Jul 2009 13:37:12 -0400 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MQlwF-0004qS-DJ for grub-devel@gnu.org; Tue, 14 Jul 2009 13:37:11 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MQkrD-0000Zu-64 for grub-devel@gnu.org; Tue, 14 Jul 2009 18:27:55 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MQlwA-0002k3-NK for grub-devel@gnu.org; Tue, 14 Jul 2009 19:37:06 +0200 Date: Tue, 14 Jul 2009 19:37:06 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090714173706.GB10523@thorin> References: <4A55AE37.1060605@zetam.org> <20090710173647.GH17114@thorin> <8330AAA8-F56B-43FF-A11B-C75952FB67B3@zetam.org> <20090712092107.ausjawz604ksgkcg-cebfxv@webmail.spamcop.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090712092107.ausjawz604ksgkcg-cebfxv@webmail.spamcop.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] unused constants in i386/boot.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2009 17:37:17 -0000 On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote: > Quoting Yves Blusseau : > >>> As long as boot/i386/pc/boot.S has the variables whose offset these macros >>> are describing, I think it's fine to keep them. > > I'd rather not keep the macros that are not used outside boot.S. They > give a wrong impression that somebody somewhere needs to know that > offset. Ok, let's remove them. I don't feel strongly about it. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."