From: wysochanski@sourceware.org <wysochanski@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/tools vgcfgbackup.c
Date: 15 Jul 2009 03:30:05 -0000 [thread overview]
Message-ID: <20090715033005.20555.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski at sourceware.org 2009-07-15 03:30:04
Modified files:
tools : vgcfgbackup.c
Log message:
Fix FAILED_INCONSISTENT case in vg_backup_single - typeo on 'if' condition.
In vg_backup_single, we should error out if we vg_read_error(vg) and the
error code we received was anything other than FAILED_INCONSISTENT.
Original code contained an error because C operator precedence.
Note - this was part of the vg_read() so no WHATS_NEW entry neceesary.
Author: Dave Wysochanski <dwysocha@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcfgbackup.c.diff?cvsroot=lvm2&r1=1.28&r2=1.29
--- LVM2/tools/vgcfgbackup.c 2009/07/01 17:00:52 1.28
+++ LVM2/tools/vgcfgbackup.c 2009/07/15 03:30:04 1.29
@@ -54,7 +54,7 @@
char **last_filename = (char **)handle;
char *filename;
- if (vg_read_error(vg) && !vg_read_error(vg) == FAILED_INCONSISTENT)
+ if (vg_read_error(vg) && (vg_read_error(vg) != FAILED_INCONSISTENT))
return ECMD_FAILED;
if (arg_count(cmd, file_ARG)) {
reply other threads:[~2009-07-15 3:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715033005.20555.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.