From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Curt Wohlgemuth <curtw@google.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: More buffer head reference leaks
Date: Wed, 15 Jul 2009 11:53:36 +0530 [thread overview]
Message-ID: <20090715062335.GA19313@skywalker> (raw)
In-Reply-To: <6601abe90907141358w3b16cdb0rb429f8d67d65dc9a@mail.gmail.com>
>
> diff -Naur orig/fs/ext4/namei.c new/fs/ext4/namei.c
> --- orig/fs/ext4/namei.c 2009-07-14 11:19:46.000000000 -0700
> +++ new/fs/ext4/namei.c 2009-07-14 11:19:28.000000000 -0700
> @@ -1498,12 +1498,14 @@
>
> sb = dir->i_sb;
> blocksize = sb->s_blocksize;
> - if (!dentry->d_name.len)
> - return -EINVAL;
> + if (!dentry->d_name.len) {
> + retval = -EINVAL;
> + goto out;
> + }
>
Do we really need those goto changes. We just return even at the label "out".
Seperating that out of the patch makes review easier
-aneesh
prev parent reply other threads:[~2009-07-15 6:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 20:58 [PATCH] ext4: More buffer head reference leaks Curt Wohlgemuth
2009-07-15 5:52 ` Aneesh Kumar K.V
2009-07-15 15:00 ` Curt Wohlgemuth
2009-07-15 15:53 ` Curt Wohlgemuth
2009-07-17 19:55 ` Curt Wohlgemuth
2009-07-17 22:19 ` Theodore Tso
2009-07-15 6:23 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715062335.GA19313@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.