Re: [PATCH 1/2] icecc: remove bb.errors on un-built compilers

[Khem Raj <raj.khem@gmail.com>]

On (15/07/09 16:52), Roman I Khimov wrote:
> Building things with icecc and BB_NUMBER_THREADS more then 1 you could see
> a lot of messages:
> 
> ERROR: no cross compiler built yet?
> 
> before gcc-cross would be properly built. There is technically nothing wrong,
> cross compiler is not there yet and it's not needed when bitbake does
> fetch-unpack-patch and other things to prepare package build. But it makes
> people uncomfortable.
> 
> We can safely kill this messages.

provided that this part of code is not executed again when cross
compiler is really needed because then we will not get the warning
where we should get it legitimately.

Thanks

-Khem


> ---
>  classes/icecc.bbclass |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/classes/icecc.bbclass b/classes/icecc.bbclass
> index 0eb2d9f..27e0e56 100644
> --- a/classes/icecc.bbclass
> +++ b/classes/icecc.bbclass
> @@ -62,7 +62,6 @@ def create_cross_env(bb,d):
>          os.stat(os.path.join(ice_dir, target_sys, 'lib', 'libstdc++.so'))
>          os.stat(os.path.join(ice_dir, target_sys, 'bin', 'g++'))
>      except: # no cross compiler built yet
> -        bb.error('no cross compiler built yet?')
>          return ""
>  
>      VERSION = icc_determine_gcc_version( os.path.join(ice_dir,target_sys,"bin","g++") )
> @@ -159,7 +158,6 @@ def create_cross_kernel_env(bb,d):
>      try:
>          os.stat(os.path.join(ice_dir, 'bin', kernel_cc))
>      except: # no cross compiler built yet
> -        bb.error('no kernel cross compiler built yet')
>          return ""
>  
>      VERSION = icc_determine_gcc_version( os.path.join(ice_dir,"bin",kernel_cc) )
> -- 
> 1.6.3.3
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel