From: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>,
git@vger.kernel.org,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCH v3] Re: git-am: fix maildir support regression: accept email file as patch
Date: Thu, 16 Jul 2009 03:00:01 +0200 [thread overview]
Message-ID: <20090716010001.GC12971@vidovic> (raw)
In-Reply-To: <7vfxcxcxg1.fsf@alter.siamese.dyndns.org>
The 15/07/09, Junio C Hamano wrote:
> We traditionally allowed a mbox file or a directory name of a maildir (but
> never an individual file inside a maildir) to be given to "git am". Even
> though an individual file in a maildir (or more generally, a piece of
> RFC2822 e-mail) is not a mbox file, it contains enough information to
> create a commit out of it, so there is no reason to reject one. Running
> mailsplit on such a file feels stupid, but it does not hurt.
Junio, I'm sorry but you missed the point.
It is not about adding a new feature. It's about keeping compatibility
with maildir. The current version _rejects_ good patches.
But, as it's very easy to move emails from a maildir _or_ have a symlink
which links to "maildir/cur" or whatever, we really should rely on the
content of the files.
--
Nicolas Sebrecht
next prev parent reply other threads:[~2009-07-16 1:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 22:19 [PATCH v3] git-am: fix maildir support regression: accept email file as patch Nicolas Sebrecht
2009-07-15 22:43 ` [PATCH v3] " Nicolas Sebrecht
2009-07-15 22:54 ` [PATCH v3] " Junio C Hamano
2009-07-15 23:56 ` Junio C Hamano
2009-07-16 1:00 ` Nicolas Sebrecht [this message]
2009-07-16 2:06 ` [PATCH v3] " Nicolas Sebrecht
2009-07-16 2:30 ` Junio C Hamano
2009-07-16 2:59 ` Nicolas Sebrecht
2009-07-16 0:49 ` Nicolas Sebrecht
2009-07-16 2:41 ` Junio C Hamano
2009-07-16 4:05 ` [PATCH v4] git-am: allow e-mail file(s) as input Nicolas Sebrecht
2009-07-16 4:10 ` [PATCH v4] " Nicolas Sebrecht
2009-07-16 5:23 ` [PATCH v5] " Nicolas Sebrecht
2009-07-16 7:09 ` Stephen Boyd
2009-07-16 7:24 ` Junio C Hamano
2009-07-16 7:50 ` [PATCH v5] " Nicolas Sebrecht
2009-07-16 8:06 ` Nicolas Sebrecht
2009-07-16 8:17 ` Johannes Sixt
2009-07-16 8:12 ` Johannes Sixt
2009-07-16 17:45 ` [PATCH v6] mailinfo: allow e-mail files " Nicolas Sebrecht
2009-07-17 1:05 ` Junio C Hamano
2009-07-17 2:20 ` [PATCH v6] " Nicolas Sebrecht
2009-07-17 10:06 ` [PATCH v6] " Nanako Shiraishi
2009-07-17 19:54 ` Junio C Hamano
2009-07-17 22:04 ` [PATCH v6] " Nicolas Sebrecht
2009-08-06 17:07 ` [PATCH v7] " Nicolas Sebrecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716010001.GC12971@vidovic \
--to=nicolas.s.dev@gmx.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.