From: Sten Spans <Sten_Spans@genua.de>
To: James Morris <jmorris@namei.org>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: security_file_lock cmd argument
Date: Thu, 16 Jul 2009 09:41:39 +0200 [thread overview]
Message-ID: <20090716074139.GB23769@false> (raw)
In-Reply-To: <alpine.LRH.2.00.0907161003550.27259@tundra.namei.org>
On Thu, Jul 16, 2009 at 10:05:47AM +1000, James Morris wrote:
> > From: Sten Spans <Sten_Spans@genua.de>
>
> This looks good, but you need to add a signed-off-by line per
> Documentation/SubmittingPatches
>
Makes sense, how about:
Pass posix-translated lock operations to security_file_lock
when invoked via sys_flock.
Signed-off-by: Sten Spans <Sten_Spans@genua.de>
--- fs/locks.c.orig 2009-07-09 11:26:45.000000000 +0200
+++ fs/locks.c 2009-07-09 11:27:24.000000000 +0200
@@ -1590,7 +1590,7 @@
if (can_sleep)
lock->fl_flags |= FL_SLEEP;
- error = security_file_lock(filp, cmd);
+ error = security_file_lock(filp, lock->fl_type);
if (error)
goto out_free;
--
GeNUA Gesellschaft für Netzwerk - und Unix-Administration mbH
Domagkstr. 7, D-85551 Kirchheim. http://www.genua.de
Tel: (089) 99 19 50-0, Fax: (089) 99 19 50 - 999
Geschäftsführer: Dr. Magnus Harlander, Dr. Michaela Harlander,
Bernhard Schneck. Amtsgericht München HRB 98238
next prev parent reply other threads:[~2009-07-16 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LRH.2.00.0907092031020.4944@tundra.namei.org>
2009-07-16 0:05 ` security_file_lock cmd argument James Morris
2009-07-16 7:41 ` Sten Spans [this message]
2009-07-16 22:04 ` James Morris
2009-07-09 9:45 Sten Spans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716074139.GB23769@false \
--to=sten_spans@genua.de \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.