All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: test I/O after EOF for growable files
Date: Thu, 16 Jul 2009 18:44:33 +0200	[thread overview]
Message-ID: <20090716164433.GA7832@lst.de> (raw)
In-Reply-To: <4A5EE0F4.3000108@redhat.com>

On Thu, Jul 16, 2009 at 10:12:36AM +0200, Kevin Wolf wrote:
> Christoph Hellwig schrieb:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Maybe include a test for reads/writes that start before EOF, so the EOF
> is somewhere in the middle of the request?

Yeah, good point.  I've commited the test as-is for now but I'll add
that case soon.

> Looks good to me otherwise (and shows that qemu-io is buggy now that raw
> doesn't have a protocol name any more).

Yeah, see the patch I sent to fix that part.

  reply	other threads:[~2009-07-16 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 21:13 [Qemu-devel] [PATCH] qemu-iotests: test I/O after EOF for growable files Christoph Hellwig
2009-07-16  8:12 ` Kevin Wolf
2009-07-16 16:44   ` Christoph Hellwig [this message]
2009-07-16 13:18 ` Blue Swirl
2009-07-16 16:45   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716164433.GA7832@lst.de \
    --to=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.