[Qemu-devel] Re: [PATCH v2] introduce on_vcpu

[Glauber Costa <glommer@redhat.com>]

On Thu, Jul 16, 2009 at 04:35:46PM -0500, Anthony Liguori wrote:
> Glauber Costa wrote:
>> on_vcpu is a qemu-kvm function that will make sure that a specific
>> piece of code will run on a requested cpu. We don't need that because
>> we're restricted to -smp 1 right now, but those days are likely to end soon.
>>
>> So for the benefit of having qemu-kvm share more code with us, I'm
>> introducing our own version of on_vcpu(). Right now, we either run
>> a function on the current cpu, or abort the execution, because it would
>> mean something is seriously wrong.
>>
>> As an example code, I "ported" kvm_update_guest_debug to use it,
>> with some slight differences from qemu-kvm.
>>
>> This is probably 0.12 material
>>
>> Signed-off-by: Glauber Costa <glommer@redhat.com>
>> CC: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  kvm-all.c |   37 +++++++++++++++++++++++++++++++------
>>  1 files changed, 31 insertions(+), 6 deletions(-)
>>
>> diff --git a/kvm-all.c b/kvm-all.c
>> index 61194b8..0c881e8 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -39,6 +39,8 @@
>>      do { } while (0)
>>  #endif
>>
>> +CPUState *current_env;
>> +
>>   
>
> That shouldn't be there anymore...
oops ;-)

>
> -- 
> Regards,
>
> Anthony Liguori
>