From: David Brownell <david-b@pacbell.net>
To: Troy Kisky <troy.kisky@boundarydevices.com>
Cc: tglx@linutronix.de, linux-mtd@lists.infradead.org
Subject: Re: [PATCH V5 1/2] mtd: nand: move layout structure into nand_ecc_ctrl
Date: Fri, 17 Jul 2009 12:46:49 -0700 [thread overview]
Message-ID: <200907171246.49342.david-b@pacbell.net> (raw)
In-Reply-To: <1247789948-5764-1-git-send-email-troy.kisky@boundarydevices.com>
On Thursday 16 July 2009, Troy Kisky wrote:
> case 2048:
> - nand_chip->ecc.layout = &atmel_oobinfo_large;
> + memcpy(&nand_chip->ecc.layout, &atmel_oobinfo_large,
> + sizeof(nand_chip->ecc.layout));
> ecc_writel(host->ecc, MR, ATMEL_ECC_PAGESIZE_2112);
> break;
Surely using structure assignment
nand_chip->ecc.layout = atmel_oobinfo_large;
would be better, everywhere?
next prev parent reply other threads:[~2009-07-17 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1247789948-5764-1-git-send-email-troy.kisky@boundarydevices.com>
[not found] ` <1247789948-5764-2-git-send-email-troy.kisky@boundarydevices.com>
2009-07-17 1:19 ` [PATCH V5 2/2] mtd: nand: Calculate better default ecc layout Troy Kisky
2009-07-23 19:14 ` Troy Kisky
2009-07-23 19:26 ` David Brownell
2009-07-23 19:38 ` Troy Kisky
2009-07-17 19:46 ` David Brownell [this message]
2009-07-17 20:20 ` [PATCH V5 1/2] mtd: nand: move layout structure into nand_ecc_ctrl Troy Kisky
2009-07-17 21:19 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907171246.49342.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.