From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Read EF-PNN, EF-OPL and override network names accordingly.
Date: Sat, 18 Jul 2009 00:40:43 -0500 [thread overview]
Message-ID: <200907180040.44024.denkenz@gmail.com> (raw)
In-Reply-To: <fb249edb0907171636w58f8af6aud94bbea0b24c5192@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Hi,
> 2009/7/14 Denis Kenzior <denkenz@gmail.com>:
> > Patch has been applied. However, I've completely (juding by 40 or so
> > commits) refactored how SIM filesystem is handled in oFono so I might
> > have introduced some bugs. Could you test to make sure it is working as
> > intended?
>
> Attaching some fixes for the new code, the test and a clean-up patch
> (feel free to drop parts). Note all the recent commits broke
> bisectability badly.
Good catches. All five have been applied and pushed. Thanks.
>
> Wouldn't it be useful for the service provider name to be available as
> SimManager property?
I really don't see any practical uses for it by the UI. Can you foresee
anything that actually needs this? Remember, it is easier to add apis later
than to modify or remove.
Regards,
-Denis
prev parent reply other threads:[~2009-07-18 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 3:14 [PATCH] Read EF-PNN, EF-OPL and override network names accordingly Andrzej Zaborowski
2009-07-14 20:53 ` Denis Kenzior
2009-07-17 23:36 ` Andrzej Zaborowski
2009-07-18 5:40 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907180040.44024.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.