From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MSEUa-0004h2-1C for mharc-grub-devel@gnu.org; Sat, 18 Jul 2009 14:18:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSEUY-0004fS-4K for grub-devel@gnu.org; Sat, 18 Jul 2009 14:18:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSEUT-0004aT-Ih for grub-devel@gnu.org; Sat, 18 Jul 2009 14:18:37 -0400 Received: from [199.232.76.173] (port=34062 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSEUT-0004aK-B9 for grub-devel@gnu.org; Sat, 18 Jul 2009 14:18:33 -0400 Received: from aybabtu.com ([69.60.117.155]:59678) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MSEUS-0002sB-Rw for grub-devel@gnu.org; Sat, 18 Jul 2009 14:18:33 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MSDP2-00034T-2A for grub-devel@gnu.org; Sat, 18 Jul 2009 19:08:53 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MSEUH-0003Th-Q7 for grub-devel@gnu.org; Sat, 18 Jul 2009 20:18:21 +0200 Date: Sat, 18 Jul 2009 20:18:21 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090718181821.GC8867@thorin> References: <20090715234038.31016.40532.stgit@mj.roinet.com> <20090715234045.31016.49690.stgit@mj.roinet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2009 18:18:38 -0000 On Thu, Jul 16, 2009 at 06:24:14PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jul 16, 2009 at 1:40 AM, Pavel Roskin wrote: > > ChangeLog: > > > >        * Makefile.in: Remove LIBLZO and enable_lzo. > >        * conf/i386-pc.rmk: Remove lzo support. > >        * configure.ac: Remove checks for lzo, don't define ENABLE_LZMA. > >        * include/grub/i386/pc/kernel.h: Define ENABLE_LZMA.  Remove lzo > >        support. > >        * kern/i386/pc/lzo1x.S: Remove. > >        * kern/i386/pc/startup.S: Remove lzo support. > >        * util/i386/pc/grub-mkimage.c: Likewise. > Is there a reason to remove lzo? I know that lzma performs much better > in terms of compression but afaik lzo doesn't create any problems nor > is compiled by default It doesn't break things, since it's barely modified, and doesn't interact with the rest of the code, but simply having more code means an added work to maintain it when we restructure things, etc. It needs to pay off in some way. > and may be desirable for some users Can you give an example? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."