From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MSEih-0007Nl-Fe for mharc-grub-devel@gnu.org; Sat, 18 Jul 2009 14:33:15 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSEie-0007Kw-MU for grub-devel@gnu.org; Sat, 18 Jul 2009 14:33:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSEiZ-0007HG-6E for grub-devel@gnu.org; Sat, 18 Jul 2009 14:33:11 -0400 Received: from [199.232.76.173] (port=57419 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSEiY-0007HC-UY for grub-devel@gnu.org; Sat, 18 Jul 2009 14:33:06 -0400 Received: from aybabtu.com ([69.60.117.155]:45270) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MSEiY-00069j-HJ for grub-devel@gnu.org; Sat, 18 Jul 2009 14:33:06 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MSDd6-0003Bw-TX for grub-devel@gnu.org; Sat, 18 Jul 2009 19:23:27 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MSEiN-0003Vk-R7 for grub-devel@gnu.org; Sat, 18 Jul 2009 20:32:55 +0200 Date: Sat, 18 Jul 2009 20:32:55 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090718183255.GF8867@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] change --enable-efiemu to --enable-efiemu64 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2009 18:33:13 -0000 On Fri, Jul 17, 2009 at 06:15:57PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Like previously discussed efiemu32 can always be compiled hence this patch This does a few more things than just toggle compile options. Could you split the patch? > diff --git a/ChangeLog b/ChangeLog > index e38ebc5..93c9b00 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,23 @@ > +2009-07-17 Vladimir Serbinenko > + > + Always compile efiemu32.o > + > + * Makefile.in (enable_efiemu): change to ... > + (enable_efiemu64): ... this > + * commands/i386/cpuid.c (grub_i386_cpuid_has_longmode): new function > + * conf/i386-pc.rmk (efiemu_mod_SOURCES): remove efiemu/i386/coredetect.c > + (efiemu32.o): always compile this target > + * configure.ac: change enable-efiemu to enable-efiemu64. > + Restrict efiemu compilation to i386-pc > + * efiemu/i386/coredetect.c: remove file > + * efiemu/main.c (grub_efiemu_load_file): return error correctly > + (grub_efiemu_autocore): fallback to efiemu32.o on amd64 if efiemu64.o > + is unavailable > + * efiemu/mm.c (grub_efiemu_mmap_init): correct comment style > + * include/grub/efiemu/efiemu.h (grub_efiemu_get_default_core_name): > + remove > + * include/grub/i386/cpuid.h: new file -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."