From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MSGAE-0002JA-Kw for mharc-grub-devel@gnu.org; Sat, 18 Jul 2009 16:05:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSGAD-0002ID-58 for grub-devel@gnu.org; Sat, 18 Jul 2009 16:05:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSGA8-0002Dx-JA for grub-devel@gnu.org; Sat, 18 Jul 2009 16:05:44 -0400 Received: from [199.232.76.173] (port=56346 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSGA8-0002Dm-Fg for grub-devel@gnu.org; Sat, 18 Jul 2009 16:05:40 -0400 Received: from aybabtu.com ([69.60.117.155]:59541) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MSGA7-0000Go-Vs for grub-devel@gnu.org; Sat, 18 Jul 2009 16:05:40 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MSF4g-0003Mj-Ew for grub-devel@gnu.org; Sat, 18 Jul 2009 20:56:00 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MSG9x-0003ju-Hi for grub-devel@gnu.org; Sat, 18 Jul 2009 22:05:29 +0200 Date: Sat, 18 Jul 2009 22:05:29 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090718200529.GC14330@thorin> References: <20090718191114.GK8867@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] Bug fix for LVM X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2009 20:05:45 -0000 On Sat, Jul 18, 2009 at 09:59:55PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Jul 18, 2009 at 9:43 PM, Bean wrote: > > On Sun, Jul 19, 2009 at 3:11 AM, Robert Millan wrote: > >> On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrote: > >>>      } > >>> > >>>    grub_raid_rescan (); > >>> +  grub_lvm_fini (); > >>> +  grub_lvm_init (); > >> > >> This is aside from this patch, but I don't see the purpose of this > >> grub_raid_rescan() function.  It's in raid.mod but only used by > >> grub-fstest, so at least it should be #ifdef'ed out, but looking at > >> what it does, it seems very ad-hoc.  It basically amounts to the > >> same you're doing with grub_lvm_fini() and grub_lvm_init().  Could > >> you fix this while at it? > > > > This is required. As raid and lvm scan device in init function, but > > grub-fstest uses loopback device, which hasn't been setup in > > grub_init_all. This code rescan raid and lvm, otherwise there won't be > > available. > > > This situation isn't strictly speaking restricted to grub-fstest then. > One would sensibly want to loopmount lvm image in grub shell. Is there > a way to do it cleanly? I think a good long-term solution is to move the scan function from grub_raid_init() to wheereever appropiate to make the scan happen dynamically everytime e.g. the iterate() function is called. However, doing this efficiently needs some work. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."