From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix when installing on pationless but partionable medium
Date: Sun, 19 Jul 2009 11:07:41 +0100 [thread overview]
Message-ID: <20090719100741.GA12723@riva.ucam.org> (raw)
In-Reply-To: <20090718191741.GM8867@thorin>
On Sat, Jul 18, 2009 at 09:17:41PM +0200, Robert Millan wrote:
> On Sat, Jul 18, 2009 at 09:01:38PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > On Sat, Jul 18, 2009 at 8:45 PM, Robert Millan<rmh@aybabtu.com> wrote:
> > > I might be missing something about this check, but GRUB doesn't require that
> > > the boot flag is present. Therefore, its non presence doesn't imply this is
> > > not a real msdos label.
> >
> > He refers to boot flag as a byte in msdos structure which can only be
> > 0x00 (not set) or 0x80 (set)
>
> Yes. GRUB's boot.img doesn't do anything with it AFAICT.
That's as may be, sure; but checking that that byte is one of the two
permitted values in all four partitions happens to be a good sanity
check for whether it's really an MS-DOS label or in fact something else.
--
Colin Watson [cjwatson@ubuntu.com]
next prev parent reply other threads:[~2009-07-19 10:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 16:41 [PATCH] Fix when installing on pationless but partionable medium Vladimir 'phcoder' Serbinenko
2009-07-17 16:51 ` Colin Watson
2009-07-18 18:45 ` Robert Millan
2009-07-18 19:01 ` Vladimir 'phcoder' Serbinenko
2009-07-18 19:17 ` Robert Millan
2009-07-19 10:07 ` Colin Watson [this message]
2009-07-22 17:16 ` Robert Millan
2009-07-22 17:36 ` Pavel Roskin
2009-07-22 17:43 ` Vladimir 'phcoder' Serbinenko
2009-07-22 17:46 ` Pavel Roskin
2009-07-26 12:53 ` Vladimir 'phcoder' Serbinenko
2009-07-18 18:42 ` Robert Millan
2009-07-18 19:00 ` Vladimir 'phcoder' Serbinenko
2009-07-18 19:22 ` Robert Millan
2009-07-18 21:28 ` Vladimir 'phcoder' Serbinenko
2009-07-22 17:22 ` Robert Millan
2009-07-22 17:45 ` Pavel Roskin
2009-07-26 13:54 ` Vladimir 'phcoder' Serbinenko
2009-07-28 17:33 ` Robert Millan
2009-07-28 21:42 ` Vladimir 'phcoder' Serbinenko
2009-07-31 15:43 ` Robert Millan
2009-07-19 10:02 ` Colin Watson
2009-07-22 17:24 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090719100741.GA12723@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.