From: Christoph Hellwig <hch@infradead.org>
To: Christian Kujau <lists@nerdbynature.de>
Cc: linux-xfs@oss.sgi.com
Subject: Re: xfstests: nslookup not found
Date: Sun, 19 Jul 2009 14:20:12 -0400 [thread overview]
Message-ID: <20090719182012.GA10936@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.01.0907191050010.6439@bogon>
On Sun, Jul 19, 2009 at 10:57:35AM -0700, Christian Kujau wrote:
> Hi,
>
> while trying to run ./check in a current xfstests tree, execution stopped
> because "nslookup" was not available. I could've just installed this tool
> but I wondered why xfstests, a filesystem testing tool, would need
> nslookup at all. Turns out that it's being used in a routine called
> "_get_fqdn", which in turn is only called once in ./new, to set a variable
> called "owner" and I ask myself: do I really want my FQDN listed in the
> testresults, that maybe even get published for analysis? I changed this
> whole _get_fqdn thingy to just "uname -n", but I'm eager to know why the
> FQDN is crucial here :-)
It uses it as email address for the test owner. In these days this
probably requires hand-editing anyway, but the fqdn is certainly
a better approximation than uname -n.
Can you resend a patch that just moves _get_fqdn and the check for
nslookup from common* into the "new" script?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-07-19 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 17:57 xfstests: nslookup not found Christian Kujau
2009-07-19 18:20 ` Christoph Hellwig [this message]
2009-07-19 22:26 ` Eric Sandeen
2009-07-19 23:57 ` Christian Kujau
2009-07-20 0:16 ` Christoph Hellwig
2009-07-20 1:46 ` [PATCH] don't fail if nslookup is not found (was: xfstests: nslookup not found) Christian Kujau
2009-07-20 9:32 ` Christoph Hellwig
2009-07-20 17:03 ` Christian Kujau
2009-07-20 17:56 ` [PATCH] don't fail if nslookup is not found Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090719182012.GA10936@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@oss.sgi.com \
--cc=lists@nerdbynature.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.