From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Robin Holt <holt@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Commit 9b57896e removed my Vaio S1 S2 keys for brightness +/-.
Date: Mon, 20 Jul 2009 00:04:11 +0100 [thread overview]
Message-ID: <20090719230411.GA14890@srcf.ucam.org> (raw)
In-Reply-To: <20090719230212.GD7426@sgi.com>
On Sun, Jul 19, 2009 at 06:02:12PM -0500, Robin Holt wrote:
> On Sun, Jul 19, 2009 at 11:26:05PM +0100, Matthew Garrett wrote:
> > On Sun, Jul 19, 2009 at 05:22:36PM -0500, Robin Holt wrote:
> > > Matthew,
> > >
> > > I am not sure whether this is a bug or just something not configured
> > > correctly. I am running Ubuntu 9.04 and finally decided to find out why
> > > the S1 and S2 buttons no longer brighten or dim the display. Prior to
> > > commit 9b57896e, they behaved equivalent to the Fn-F5 and Fn-F6 keys
> > > for brightness up/down.
> >
> > I suspect that they're now working correctly, whereas previously they
> > weren't. Do they generate input events when you press them? You can
> > probably map them back to KEY_BRIGHTNESSUP and KEY_BRIGHTNESSODNW.
>
> You are correct. They now seem to generate XF86Launch1 and XF86Launch2.
That's what I'd expect. Previously we were decoding some of the hotkeys
incorrectly, resulting in the wrong codes being sent.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2009-07-19 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 22:22 Commit 9b57896e removed my Vaio S1 S2 keys for brightness +/- Robin Holt
2009-07-19 22:26 ` Matthew Garrett
2009-07-19 23:02 ` Robin Holt
2009-07-19 23:04 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090719230411.GA14890@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.