From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org, Barry Song <21cnbao@gmail.com>,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 1/2] clean-up according to feedback
Date: Mon, 20 Jul 2009 11:35:48 +0100 [thread overview]
Message-ID: <20090720103548.GA5215@sirena.org.uk> (raw)
In-Reply-To: <s5h7hy37ikp.wl%tiwai@suse.de>
On Mon, Jul 20, 2009 at 12:30:14PM +0200, Takashi Iwai wrote:
> Barry Song wrote:
> > Signed-off-by: Barry Song <21cnbao@gmail.com>
> Could you give a proper changelog and subject lines at each post please?
> Both are very important for later reviews.
Yes, please. If you could also answer the questions I asked about why
you're creating a new DAI that'd be helpful.
next prev parent reply other threads:[~2009-07-20 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 10:28 [PATCH 0/2]ad1938 dai and board driver clean-up according to feedback Barry Song
2009-07-20 10:28 ` [PATCH 1/2] " Barry Song
2009-07-20 10:30 ` Takashi Iwai
2009-07-20 10:35 ` Mark Brown [this message]
2009-07-20 10:28 ` [PATCH 2/2] " Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720103548.GA5215@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.