All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-io: reject invalid pattern
Date: Mon, 20 Jul 2009 14:33:22 +0200	[thread overview]
Message-ID: <20090720123322.GB9199@lst.de> (raw)
In-Reply-To: <4A64254E.8030000@redhat.com>

On Mon, Jul 20, 2009 at 10:05:34AM +0200, Kevin Wolf wrote:
> > + * Because the pattern is used as an argument to memset it must evaluate
> > + * to an unsigned integer that fits into a single byte.
> 
> + * Returns the pattern byte or -1 in case arg does not contain a valid
> pattern
> 

> > +			pattern = parse_pattern(optarg);
> > +			if (pattern < 0)
> > +				return 0;
> 
> Coding style (braces).
> 
> Looks good to me otherwise.

Thanks, I've resent an updated version.

      reply	other threads:[~2009-07-20 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-19 23:19 [Qemu-devel] [PATCH] qemu-io: reject invalid pattern Christoph Hellwig
2009-07-20  8:05 ` Kevin Wolf
2009-07-20 12:33   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090720123322.GB9199@lst.de \
    --to=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.